backend: improve backend api and initialization #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
notify-backend-started
branch
from
23ed98a
to
6dda28e
Compare
julianoes
approved these changes
Apr 10, 2018
backend/src/backend_api.h
Outdated
| @@ -2,7 +2,7 @@ | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
| __attribute__((visibility("default"))) int runBackend(int mavlink_listen_port); | |||
| __attribute__((visibility("default"))) void runBackend(int mavlink_listen_port, void (*onServerStarted)(void*), void *context); | |||
There was a problem hiding this comment.
Missing #pragma once in this file.
There was a problem hiding this comment.
Good catch! Thanks!
There was a problem hiding this comment.
That's fixed.
JonasVautherin
force-pushed
the
notify-backend-started
branch
from
6dda28e
to
2e0ba43
Compare
JonasVautherin
force-pushed
the
notify-backend-started
branch
from
2e0ba43
to
5f00f15
Compare
| dronecore::backend::ConnectionInitiator<dronecore::DroneCore> _connection_initiator; | ||
| std::unique_ptr<grpc::Server> _server; | ||
| private: | ||
| DroneCore _dc; |
There was a problem hiding this comment.
Not reference ? I don't know, I'm just asking.
There was a problem hiding this comment.
No, because backend.cpp is actually the one owning the object. It has to be created somewhere, right? :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a callback notifying when the gRPC server is started to the backend C api. This is necessary when the frontend starts the backend on the phone, because it needs to wait for the gRPC server to be started before it can initiate a connection.